Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Jun 5, 2023

  • Respect as_objects flag in AuthApi.get_users and other methods.
  • Allow passing query parameters to get_users, to support filtering/search/pagination.
  • Add AuthApi.keycloak_admin_client to expose the KeycloakAdmin client (from the python-keycloak package) we're using. This gives users access to a much larger portion of the keycloak api.
  • Remove groups, realm_roles and is_admin fields from the user schema, because they required (costly) separate API calls for the sole purpose of determining whether a user is a REP sys-admin user. For that, one can now use the AuthApi.user_is_admin method. Also, to determine whether a user is admin we now query admin keys from the JMS Api, rather than using hardcoded values.
  • Support and test token-exchange for impersonation

@FedericoNegri FedericoNegri linked an issue Jun 5, 2023 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Jun 5, 2023
@FedericoNegri FedericoNegri marked this pull request as ready for review June 5, 2023 08:24
@FedericoNegri FedericoNegri requested a review from ojkoenig June 5, 2023 08:27
Copy link
Contributor

@ojkoenig ojkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, made some detail/tiny comments in the code

@FedericoNegri FedericoNegri merged commit 31c5e9b into main Jun 6, 2023
@FedericoNegri FedericoNegri deleted the fnegri/rework_auth_api branch June 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve AuthApi

3 participants