Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

Description

As reported by Quanqing Yan (Ansys Forming), output files and parameter ids in the success criteria were silently ignored and not sent through the REST API.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have tested these changes locally and verified that they work as intended.
  • I have updated any documentation as needed to reflect these changes (if appropriate)
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.
  • Unit tests have been added (if appropriate)
  • Test-cases have been added (if appropriate)
  • Testing instructions have been added (if appropriate)

@FedericoNegri FedericoNegri added the bug Something isn't working label Oct 26, 2023
@FedericoNegri FedericoNegri marked this pull request as ready for review October 26, 2023 16:29
@FedericoNegri FedericoNegri merged commit 18b74ee into main Oct 27, 2023
@FedericoNegri FedericoNegri deleted the fnegri/fix_success_criteria branch November 15, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants