fix: stage dependencies #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
Member
Author
|
If not, when releasing, your original 'smoke-tests' stage won't run and it will not allow the rest of the workflow to proceed. Better to handle everything in one single location also, rather than 2 different stages |
FedericoNegri
approved these changes
Feb 6, 2024
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
looks good, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing smoke test sections. Both new smoke test conditions should be merged into a single stage with proper conditions defined to skip.