Set username based on token #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set username based on token
github-actions
bot
added
dependencies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 92.87% 92.82% -0.06%
==========================================
Files 61 61
Lines 2247 2258 +11
==========================================
+ Hits 2087 2096 +9
- Misses 160 162 +2 ☔ View full report in Codecov by Sentry. |
PipKat
reviewed
Feb 26, 2024
nezgrath
reviewed
Feb 27, 2024
Raise exception when username passed does not match preferred_username
PipKat
reviewed
Feb 27, 2024
PipKat
approved these changes
Feb 27, 2024
Member
PipKat
left a comment
PipKat
left a comment
There was a problem hiding this comment.
LGTM but I can only reviewing docstring content. I can't judge if the code is acceptable.
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
Please also add a test in test_client.py.
Move scope of username logic
FedericoNegri
approved these changes
Feb 28, 2024
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
Looks good, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set username based on token
Description
The username field is currently set when a client is instantiated. Due to different auth workflows, the username may not match the preferred username defined in the auth token. This PR attempts to adjust the username based on the auth token.
Checklist
Please complete the following checklist before submitting your pull request: