Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Mar 12, 2024

Description

Auto-generate type hints for JMS and Auth resources to improve autocompletion and browsing through the resource definitions.

before:
image

after:
image

Checklist

  • I have tested these changes locally.
  • I have added unit tests (if appropriate).
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

Passing nighly build for Python 3.9-3.12: https://github.com/ansys/pyhps/actions/runs/8247610704

@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (a4866ce) to head (385da3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   93.36%   93.25%   -0.12%     
==========================================
  Files          61       61              
  Lines        2232     2267      +35     
==========================================
+ Hits         2084     2114      +30     
- Misses        148      153       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedericoNegri FedericoNegri marked this pull request as ready for review March 12, 2024 09:13
@FedericoNegri FedericoNegri added the enhancement New features or code improvements label Mar 12, 2024
@FedericoNegri FedericoNegri requested a review from ojkoenig March 12, 2024 09:53
@FedericoNegri FedericoNegri merged commit 7e1767c into main Mar 12, 2024
@FedericoNegri FedericoNegri deleted the fnegri/resources_type_hints branch March 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants