support more generic oidc #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 93.75% 93.25% -0.51%
==========================================
Files 64 64
Lines 2435 2489 +54
==========================================
+ Hits 2283 2321 +38
- Misses 152 168 +16 ☔ View full report in Codecov by Sentry. |
FedericoNegri
approved these changes
Aug 20, 2024
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
Left a minor comment about removing a warning, otherwise looks good to me.
Since this is backward compatible, can be merged at any time.
I guess proper testing against Ansys ID needs to happen elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scaler uses PyHPS and pyHPS didn't support OIDC discovery, only hardcoded things for keycloak, add those new features and a new one to allow grabbing the auth_url from JMS instead of the client needing to know it.
Checklist