Skip to content

Conversation

@RajaPiseD
Copy link
Collaborator

@RajaPiseD RajaPiseD commented Aug 2, 2024

Description

Changes to replace ansft calls with calls to data transfer service using python client of data transfer service

Data transfer binary is downloaded from data transfer server and started as a worker

Below operations are now performed using data transfer worker:

  1. Upload of files (input files and execution scripts)
  2. Download of files
  3. Upload of project archive
  4. Download of project archive

Checklist

  • I have tested these changes locally.
  • I have added unit tests (if appropriate).
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 2, 2024
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (c44d62b) to head (eb3dd4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/hps/client/jms/api/project_api.py 90.26% 11 Missing ⚠️
src/ansys/hps/client/client.py 77.50% 9 Missing ⚠️
src/ansys/hps/client/jms/api/jms_api.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   93.21%   92.55%   -0.66%     
==========================================
  Files          64       64              
  Lines        2489     2594     +105     
==========================================
+ Hits         2320     2401      +81     
- Misses        169      193      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RajaPiseD RajaPiseD marked this pull request as ready for review September 4, 2024 05:24
@FedericoNegri FedericoNegri merged commit 21c741b into main Sep 5, 2024
@FedericoNegri FedericoNegri deleted the rajapise/dts-integration branch September 5, 2024 09:12
"pydantic>=1.10.0",
"PyJWT>=2.8.0"
"PyJWT>=2.8.0",
"ansys-hps-data-transfer-client@git+https://github.com/ansys-internal/hps-data-transfer-client.git@main#egg=ansys-hps-data-transfer-client"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedericoNegri @RajaPiseD I want to bring to your attention that adding dependencies using the git specifier is not valid when uploading packages to PyPI. The Python Package Index will reject any uploads containing dependencies specified like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto we're aware, that's currently an internal dependency which is meant to either be incorporated in pyhps directly or become an open source pyansys package on its own. Either way, it's a prerequisite for the next pyhps release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants