-
Notifications
You must be signed in to change notification settings - Fork 0
Integrate with data transfer worker #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 93.21% 92.55% -0.66%
==========================================
Files 64 64
Lines 2489 2594 +105
==========================================
+ Hits 2320 2401 +81
- Misses 169 193 +24 ☔ View full report in Codecov by Sentry. |
| "pydantic>=1.10.0", | ||
| "PyJWT>=2.8.0" | ||
| "PyJWT>=2.8.0", | ||
| "ansys-hps-data-transfer-client@git+https://github.com/ansys-internal/hps-data-transfer-client.git@main#egg=ansys-hps-data-transfer-client" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedericoNegri @RajaPiseD I want to bring to your attention that adding dependencies using the git specifier is not valid when uploading packages to PyPI. The Python Package Index will reject any uploads containing dependencies specified like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgepiloto we're aware, that's currently an internal dependency which is meant to either be incorporated in pyhps directly or become an open source pyansys package on its own. Either way, it's a prerequisite for the next pyhps release.
Description
Changes to replace ansft calls with calls to data transfer service using python client of data transfer service
Data transfer binary is downloaded from data transfer server and started as a worker
Below operations are now performed using data transfer worker:
Checklist