Add explicit mode specification for parameters #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys/pyhps into pengeler/laki-reqs-parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 65 65
Lines 2894 2894
=======================================
Hits 2534 2534
Misses 360 360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ojkoenig
requested changes
Feb 28, 2025
Contributor
ojkoenig
left a comment
ojkoenig
left a comment
There was a problem hiding this comment.
Looked through it, might have found one error in mapdl_motorbike_frame example, see comment
4 tasks
ojkoenig
approved these changes
Mar 19, 2025
Contributor
ojkoenig
left a comment
ojkoenig
left a comment
There was a problem hiding this comment.
Please coordinate with Federico when it can be merged
FedericoNegri
approved these changes
Mar 27, 2025
engpas
changed the title
engpas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update schemas, resources, examples and tests to reflect new parameter handling in jms.
See #553
Checklist