Extend examples to include execution script parameter handling #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys/pyhps into pengeler/laki-reqs-parameters
…m/ansys/pyhps into pengeler/exec-script-param-return
for more information, see https://pre-commit.ci
ojkoenig
approved these changes
Apr 6, 2025
Contributor
ojkoenig
left a comment
ojkoenig
left a comment
There was a problem hiding this comment.
Thanks for following up on this.
Approved your PR, with one comment.
I wonder if there is a better name than "python_two_bar_truss_unmapped' for the example, as I struggle a bit with the term 'unmapped' in this context.
Maybe
'python_two_bar_truss_params_in_exec_script'
or
'python_two_bar_truss_exec_script'
would be better?
Contributor
Author
|
Revised example description and renamed example to python_two_bar_truss_params_in_exec_script. |
ojkoenig
approved these changes
Apr 8, 2025
engpas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples to make use of unmapped parameter transfers.