-
Notifications
You must be signed in to change notification settings - Fork 0
Prep for new release targeting the upcoming HPS 1.3 #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 87.62% 87.64% +0.02%
==========================================
Files 65 65
Lines 2999 3004 +5
==========================================
+ Hits 2628 2633 +5
Misses 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ojkoenig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes, very happy that you go all the efforts on version compatibility, even adding backward compatibility tests.
Prep in view of a new release targeting the upcoming HPS 1.3.
Adding
v1.3.45as HPS version we can run tests againstUpdated the compatibility table (last row and last column are new)

Added backward compatibility tests to make sure that the current PyHPS is still compatible with HPS 1.2 as documented. This is true apart for:
Modified the tests to report explicit version dependent expected failures. Reasons for additional skipped/x-failed tests are reported in the pytest summary
