Skip to content

Migrating techdemos from pymapdl repository #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 24, 2022
Merged

Migrating techdemos from pymapdl repository #12

merged 24 commits into from
Nov 24, 2022

Conversation

@clatapie
Copy link
Collaborator

@clatapie clatapie commented Nov 22, 2022

Closes #8

@clatapie clatapie requested a review from RobPasMue November 22, 2022 10:09
@clatapie clatapie linked an issue Nov 22, 2022 that may be closed by this pull request
Migrate techdemos from PyMAPDL repository #8
Closed
3 tasks
@clatapie clatapie self-assigned this Nov 22, 2022
@github-actions github-actions bot added dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related labels Nov 22, 2022
germa89
germa89 reviewed Nov 22, 2022
View reviewed changes
clatapie and others added 15 commits November 22, 2022 14:01
@clatapie @germa89
Apply suggestions from code review
477e900 
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie
Adding jupyter_sphinx extension
65b608c
@clatapie
Simplifying navigation on the website
6a01d58
@clatapie
Reorganizing the repository & Fixing image display
d104c90
@RobPasMue
Solving missing reqs
6c785c3
@RobPasMue
Merge branch 'maint/migrating_techdemos_from_pymapdl_repository' of h…
603be28 
…ttps://github.com/pyansys/pymapdl-techdemos into maint/migrating_techdemos_from_pymapdl_repository
@RobPasMue
Solving indexing errors
91a906a
@RobPasMue
Adding breadcrumbs
663e750
@clatapie
Fixing warnings in build documentation
f001449
@clatapie
Fixing Build HTML documentation issue
087b1bc
@clatapie
Fixing Build HTML documentation issue #2
3bbd788
@clatapie
Fixing Build HTML documentation issue 3
2178840
@clatapie
Fixing Build HTML documentation issue 4
9e08abd
@RobPasMue
Merge branch 'main' into maint/migrating_techdemos_from_pymapdl_repos…
169baa3 
…itory
@clatapie
Merge branch 'maint/migrating_techdemos_from_pymapdl_repository' of h…
9c14dea 
…ttps://github.com/pyansys/pymapdl-techdemos into maint/migrating_techdemos_from_pymapdl_repository
@clatapie clatapie marked this pull request as ready for review November 23, 2022 11:39
RobPasMue
RobPasMue reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that the techdemos inside are effectively the same as they already where in PyMAPDL. Thanks @clatapie, only the landing page is missing! Request review once you have it.

RobPasMue
RobPasMue approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only some small comments. Ready to be merged =)

@RobPasMue RobPasMue requested a review from germa89 November 24, 2022 07:34
@RobPasMue
Copy link
Member

RobPasMue commented Nov 24, 2022

Once this PR is merged, we should start thinking about:

  • Removing techdemos from PyMAPDL repository
  • Linking PyMAPDL's documentation to this repository

Pinging @germa89 for acknowledgment

@clatapie @RobPasMue
Apply suggestions from code review
4573791 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@RobPasMue
Copy link
Member

RobPasMue commented Nov 24, 2022

Well, just so that @clatapie doesn't get stuck, I'm going to merge this PR. Nonetheless @germa89 if you see anything you want to change let us know and we can work on it later =)

@RobPasMue RobPasMue merged commit f11243e into main Nov 24, 2022
@RobPasMue RobPasMue deleted the maint/migrating_techdemos_from_pymapdl_repository branch November 24, 2022 09:01
germa89
germa89 reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89
Copy link
Contributor

germa89 commented Nov 24, 2022

@maromer0 please have a look of this PR. It has a lot of interesting things we will discuss in our meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@clatapie clatapie

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate techdemos from PyMAPDL repository

4 participants

@clatapie @RobPasMue @germa89