Fix numpy indexing #517
Merged
Fix numpy indexing #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
approved these changes
Nov 21, 2024
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
LGTM! Thanks @akaszynski
What about dropping Python 3.9? Maybe it's the moment to do so too. The rest of the libraries have also dropped it (some are still supporting it based on specific customer/user needs).
Collaborator
Author
|
Python 3.9 EOL is 25 Oct 2024 and there are a few (big) users out there using this that will need 3.9 up until the last day. Python 3.13 support is waiting on VTK 9.4, which should be out by the end of the year. |
Member
Yep, we've been pushing them for that too.. https://gitlab.kitware.com/vtk/vtk/-/issues/19489#note_1592965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix numpy indexing causing unit testing to fail.
Also: