principal_nodal_stress #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaszynski
reviewed
Jul 5, 2021
akaszynski
reviewed
Jul 5, 2021
ansys/mapdl/reader/rst.py
Outdated
| """ | ||
| # get component stress | ||
| nodenum, stress = self.nodal_stress(rnum) | ||
| nodenum, stress = self.nodal_stress(rnum,nodes) |
Collaborator
There was a problem hiding this comment.
Suggested change
| nodenum, stress = self.nodal_stress(rnum,nodes) | |
| nodenum, stress = self.nodal_stress(rnum, nodes) |
akaszynski
approved these changes
Jul 5, 2021
Collaborator
|
Nice work! I made two minor whitespace changes, but other than that good job figuring out how to create a branch and submit a PR! |
Contributor
Author
Soory . What does the sentence "but other than that good job figuring out how to create a branch and submit a PR!" mean ? |
Collaborator
|
Thank you for this pull request! |
Contributor
Author
|
Very happy to that I can do some contributions to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to improve principal_nodal_stress() API to add nodes option.