Skip to content

Conversation

@RobPasMue
Copy link
Member

As title says.

@RobPasMue RobPasMue requested a review from germa89 November 15, 2022 07:09
@RobPasMue RobPasMue self-assigned this Nov 15, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@RobPasMue
Copy link
Member Author

Also, @germa89 @clatapie you should run pre-commit autoupdate from time to time to update your pre-commit hook versions. I also did it in this PR.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1627 (20281ff) into main (8850205) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   82.84%   82.91%   +0.06%     
==========================================
  Files          44       44              
  Lines        7151     7151              
==========================================
+ Hits         5924     5929       +5     
+ Misses       1227     1222       -5     

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit e914592 into main Nov 15, 2022
@germa89 germa89 deleted the maint/flake8 branch November 15, 2022 17:03
@germa89
Copy link
Collaborator

germa89 commented Nov 15, 2022

Also, @germa89 @clatapie you should run pre-commit autoupdate from time to time to update your pre-commit hook versions. I also did it in this PR.

I presume that would update the file .pre-commit-config.yaml... right?

@RobPasMue
Copy link
Member Author

Also, @germa89 @clatapie you should run pre-commit autoupdate from time to time to update your pre-commit hook versions. I also did it in this PR.

I presume that would update the file .pre-commit-config.yaml... right?

Yep, that's right =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants