Documenting differences between MAPDL and PyMAPDL #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
requested review from
PipKat,
akaszynski,
koubaa,
mikerife and
pmaroneh
Collaborator
Author
|
@pvargasm please your part (about plotting) in the corresponding section. @mikerife and @pmaroneh please do check the text regarding the listing. I presume there are many things to fix. @PipKat if you can have a look (maybe not yet, just wait for the comments) @koubaa and @akaszynski for further input/guidance |
koubaa
approved these changes
Dec 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 85.52% 85.43% -0.10%
==========================================
Files 45 45
Lines 7591 7591
==========================================
- Hits 6492 6485 -7
- Misses 1099 1106 +7 |
Contributor
|
Hi @germa89 , nice addition! LGTM. |
pmaroneh
approved these changes
Dec 22, 2022
mikerife
reviewed
Dec 22, 2022
mikerife
left a comment
mikerife
left a comment
There was a problem hiding this comment.
Nice compact explanation! LGTM too. Mike
PipKat
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
koubaa
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
PipKat
reviewed
Dec 22, 2022
PipKat
approved these changes
Dec 22, 2022
* Update faq.rst * fixing vale. Co-authored-by: German <germanmartinezayuso@gmail.com>
germa89
commented
Dec 23, 2022
germa89
commented
Dec 23, 2022
Thank you Kathy! Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
germa89
commented
Dec 23, 2022
germa89
commented
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation about differences between MAPDL and PyMAPDL.
Close #1723