Fixing release process #1775
Closed
Fixing release process #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We can probably do an action with all the sorting logic. |
github-actions
bot
added
CI/CD
Contributor
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
=========================================
+ Coverage 0 81.55% +81.55%
=========================================
Files 0 45 +45
Lines 0 7743 +7743
=========================================
+ Hits 0 6315 +6315
- Misses 0 1428 +1428 |
Collaborator
Author
|
The release process works, and pyansys actions hasn't incorporated the changes we demanded. Hence, I prefer to not modify anything for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same old story. PyMAPDL release process can't really be constrained by the pyansys actions. Hence we either flexibilize them or we go for another route.
In #1782 we went back to the old release procedure given pyansys actions wasn't really allowing us to keep our workflow approach.
Some changes need to be done on the actions side: ansys/actions#136
Until then, nothing can be done.