Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 15, 2025

Description

Reduce secrets

Issue linked

Close #4247

Checklist

Copilot AI review requested due to automatic review settings October 15, 2025 11:02
@germa89 germa89 requested a review from a team as a code owner October 15, 2025 11:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces secret exposure in GitHub Actions workflows by removing unnecessary secret declarations and environment variable configurations.

  • Removes unused GITHUB_TOKEN environment variable from migrator workflow
  • Removes MeiliSearch API key environment variables from CI workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/migrator.yml Removes unused GITHUB_TOKEN environment variable from git configuration step
.github/workflows/ci.yml Removes MeiliSearch API key environment variables from global environment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (e1e45cf) to head (4696aaa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4261   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         193      193           
  Lines       15720    15720           
=======================================
  Hits        14353    14353           
  Misses       1367     1367           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Oct 15, 2025

@Revathyvenugopal162 can you confirm that MEILISEARCH secrets are not needed?

@germa89 germa89 enabled auto-merge (squash) October 15, 2025 11:59
@Revathyvenugopal162
Copy link
Contributor

Revathyvenugopal162 commented Oct 15, 2025

@germa89 Thanks for removing the token, yes it is no longer required.

@germa89
Copy link
Collaborator Author

germa89 commented Oct 16, 2025

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit c2d3ffb into main Oct 16, 2025
50 checks passed
@germa89 germa89 deleted the ci/reducing-secret-exposure branch October 16, 2025 09:00
clatapie pushed a commit that referenced this pull request Oct 16, 2025
* ci: remove Meilisearch API keys from CI workflow environment

* ci: remove GITHUB_TOKEN env from migrator workflow clone step

* chore: adding changelog file 4261.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimize secret exposure

4 participants