Skip to content

Use ansys-tools-path #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jun 1, 2023
Merged

Use ansys-tools-path #231

merged 35 commits into from
Jun 1, 2023

Conversation

@koubaa
Copy link
Collaborator

@koubaa koubaa commented May 1, 2023 •
edited
Loading

Locate the mechanical installation using ansys-tools-path

Also integrate it for embedding on windows. On linux, its not possible since embedding is tied to the linux version whose environment is pre-configured (usually) using aisol/.workbench_lite

@koubaa koubaa requested review from germa89 and samigithub2022 May 1, 2023 15:42
@koubaa koubaa marked this pull request as draft May 1, 2023 15:42
germa89
germa89 approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But don't forget to add the package to pyproject.tml or setup.py.

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels May 8, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 8, 2023
@github-actions github-actions bot added the CI/CD label May 12, 2023
@koubaa koubaa marked this pull request as ready for review May 12, 2023 18:16
@koubaa koubaa merged commit 5dcc40c into main Jun 1, 2023
@koubaa koubaa deleted the mkoubaa/ansys-tools-path branch June 1, 2023 15:00
@koubaa koubaa mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 approved these changes

@samigithub2022 samigithub2022 Awaiting requested review from samigithub2022

Assignees

No one assigned

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa @germa89 @RobPasMue