Skip to content

Conversation

@anskhanson
Copy link
Collaborator

@anskhanson anskhanson commented Aug 31, 2023

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new methods to rst file for updated API script(\doc\source\api)
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #162 (6b8986a) into main (e7346be) will increase coverage by 0.17%.
Report is 11 commits behind head on main.
The diff coverage is 76.08%.

❗ Current head 6b8986a differs from pull request most recent head 51541fc. Consider uploading reports for the commit 51541fc to get more accurate results

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   56.20%   56.38%   +0.17%     
==========================================
  Files          20       20              
  Lines        3112     3150      +38     
==========================================
+ Hits         1749     1776      +27     
- Misses       1363     1374      +11     
Files Changed Coverage Δ
src/ansys/sherlock/core/errors.py 90.43% <55.55%> (-0.77%) ⬇️
src/ansys/sherlock/core/parts.py 52.34% <69.56%> (+1.26%) ⬆️
src/ansys/sherlock/core/types/parts_types.py 60.00% <100.00%> (+10.00%) ⬆️

@ansjmoody ansjmoody requested a review from ansnfernand August 31, 2023 14:42
@anskhanson anskhanson requested a review from ansjmoody September 5, 2023 21:23
…pdate parts list from AVL. Specified keyword parameter in error constructor.
dependabot bot and others added 6 commits September 14, 2023 11:09
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Moody <ansjmoody@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Moody <110494049+ansjmoody@users.noreply.github.com>
ansys-pwalters and others added 10 commits September 14, 2023 11:09
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ansjmoody ansjmoody merged commit d891323 into main Sep 14, 2023
@ansjmoody ansjmoody deleted the keith/api/update_parts_from_AVL branch September 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants