Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • n/a Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 56.90%. Comparing base (fa060f9) to head (c9ef51c).

Files Patch % Lines
src/ansys/sherlock/core/project.py 4.76% 20 Missing ⚠️
src/ansys/sherlock/core/errors.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   57.21%   56.90%   -0.31%     
==========================================
  Files          21       21              
  Lines        3592     3618      +26     
==========================================
+ Hits         2055     2059       +4     
- Misses       1537     1559      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand force-pushed the importProjectZipArchive branch from ab2392a to c9ef51c Compare February 26, 2024 13:48
@ansnfernand ansnfernand merged commit 50c3426 into main Feb 27, 2024
@ansnfernand ansnfernand deleted the importProjectZipArchive branch February 27, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants