Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • n/a Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 57.29%. Comparing base (50c3426) to head (e3a86e1).

Files Patch % Lines
src/ansys/sherlock/core/project.py 50.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   56.90%   57.29%   +0.38%     
==========================================
  Files          21       21              
  Lines        3618     3646      +28     
==========================================
+ Hits         2059     2089      +30     
+ Misses       1559     1557       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody merged commit 4819c28 into main Feb 28, 2024
@ansjmoody ansjmoody deleted the importProjectZipSingleMode branch February 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants