Skip to content

Conversation

@anskhanson
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [n/a] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 57.29%. Comparing base (d07b4ae) to head (271e40f).

Files Patch % Lines
src/ansys/sherlock/core/project.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   57.23%   57.29%   +0.05%     
==========================================
  Files          21       21              
  Lines        3926     3950      +24     
==========================================
+ Hits         2247     2263      +16     
- Misses       1679     1687       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anskhanson anskhanson requested a review from ansjmoody May 16, 2024 20:20
@ansjmoody ansjmoody merged commit 8f882bd into main May 22, 2024
@ansjmoody ansjmoody deleted the keith/exportproject branch May 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants