Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Jun 10, 2024

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@github-actions github-actions bot added the testing Anything related to tests label Jun 10, 2024
@codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.32%. Comparing base (6ebc536) to head (da969dc).

Files Patch % Lines
src/ansys/sherlock/core/layer.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   57.29%   57.32%   +0.03%     
==========================================
  Files          21       21              
  Lines        3950     3972      +22     
==========================================
+ Hits         2263     2277      +14     
- Misses       1687     1695       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand requested a review from ansjmoody June 10, 2024 09:55
@ansnfernand ansnfernand added the enhancement New features or code improvements label Jun 10, 2024
@ansnfernand ansnfernand linked an issue Jun 10, 2024 that may be closed by this pull request
@ansjmoody ansjmoody merged commit f90064f into main Jun 11, 2024
@ansjmoody ansjmoody deleted the deleteMountPoints branch June 11, 2024 15:50
@ansnfernand ansnfernand self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API: Delete Mount Points

3 participants