Skip to content

Conversation

@ansjmoody
Copy link
Collaborator

@ansjmoody ansjmoody commented Jul 11, 2024

This includes changes to unrelated code for code consistency and a missing unit test.

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [na] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jul 11, 2024
@ansjmoody ansjmoody requested a review from ansnfernand July 11, 2024 21:08
@ansjmoody ansjmoody force-pushed the updatePartsListValidationProps branch from 4220394 to 6ca78ac Compare July 11, 2024 21:40
@ansjmoody ansjmoody force-pushed the updatePartsListValidationProps branch from 6ca78ac to def2e1a Compare July 12, 2024 15:53
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Jul 12, 2024
@ansjmoody ansjmoody enabled auto-merge (squash) July 12, 2024 15:56
@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.82%. Comparing base (b6db40f) to head (def2e1a).

Files Patch % Lines
src/ansys/sherlock/core/analysis.py 58.06% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   57.63%   57.82%   +0.19%     
==========================================
  Files          21       21              
  Lines        4159     4185      +26     
==========================================
+ Hits         2397     2420      +23     
- Misses       1762     1765       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody merged commit d5c4054 into main Jul 12, 2024
@ansjmoody ansjmoody deleted the updatePartsListValidationProps branch July 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants