Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand added the enhancement New features or code improvements label Jul 16, 2024
@ansnfernand ansnfernand requested a review from anskhanson July 16, 2024 14:39
@ansnfernand ansnfernand linked an issue Jul 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jul 16, 2024
@ansnfernand ansnfernand self-assigned this Jul 16, 2024
@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 51.89873% with 38 lines in your changes missing coverage. Please review.

Project coverage is 57.63%. Comparing base (1ca31ac) to head (510587f).

Files Patch % Lines
src/ansys/sherlock/core/model.py 44.11% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   57.75%   57.63%   -0.12%     
==========================================
  Files          21       21              
  Lines        4244     4322      +78     
==========================================
+ Hits         2451     2491      +40     
- Misses       1793     1831      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand requested review from ansjmoody and removed request for anskhanson July 18, 2024 08:57
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 19, 2024
@ansnfernand ansnfernand merged commit a75b3ff into main Jul 23, 2024
@ansnfernand ansnfernand deleted the exportFEAModel branch July 23, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API: Export FEA Model

3 participants