Skip to content

Conversation

@anskhanson
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.61%. Comparing base (2528c0d) to head (3a0d229).

Files Patch % Lines
src/ansys/sherlock/core/launcher.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   57.63%   57.61%   -0.03%     
==========================================
  Files          21       21              
  Lines        4322     4327       +5     
==========================================
+ Hits         2491     2493       +2     
- Misses       1831     1834       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anskhanson anskhanson requested a review from ansnfernand July 23, 2024 14:39
@anskhanson anskhanson added the enhancement New features or code improvements label Jul 23, 2024
@anskhanson anskhanson self-assigned this Jul 23, 2024
@ansnfernand ansnfernand linked an issue Jul 23, 2024 that may be closed by this pull request
@ansnfernand ansnfernand force-pushed the keith/update_launcher_for_linux branch from e33b54c to e295b6e Compare July 23, 2024 15:23
@ansnfernand ansnfernand enabled auto-merge (squash) July 23, 2024 15:23
@ansnfernand ansnfernand merged commit 48d6061 into main Jul 23, 2024
@ansnfernand ansnfernand deleted the keith/update_launcher_for_linux branch July 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check Linux Compatability

3 participants