Skip to content

Conversation

@anskhanson
Copy link
Collaborator

Updated ReadMe with instructions for setting up the environment variables for Linux and added links to the tutorial videos.

Checklist:

  • [n/a] Run unit tests and make sure they all pass
  • [n/a] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [n.a] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [n/a] Add new classes to rst files, located at: \doc\source\api
  • [n/a] Generate documentation
  • [n/a] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [n/a] Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@anskhanson anskhanson added the bug Something isn't working label Jul 26, 2024
@anskhanson anskhanson assigned anskhanson and unassigned anskhanson Jul 26, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 26, 2024
@anskhanson anskhanson linked an issue Jul 26, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.61%. Comparing base (b4ed83e) to head (8cdb2db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   57.61%   57.61%           
=======================================
  Files          21       21           
  Lines        4327     4327           
=======================================
  Hits         2493     2493           
  Misses       1834     1834           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anskhanson anskhanson requested a review from ansnfernand July 29, 2024 20:50
@ansnfernand ansnfernand merged commit 2d3af4f into main Jul 30, 2024
@ansnfernand ansnfernand deleted the keith/update_readme_for_launcher branch July 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

launcher.py - launch_sherlock() needs updated for the Linux install path

3 participants