Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand linked an issue Aug 1, 2024 that may be closed by this pull request
@ansnfernand ansnfernand requested a review from ansjmoody August 1, 2024 14:22
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Aug 1, 2024
@ansnfernand ansnfernand force-pushed the addModelingRegion branch 3 times, most recently from 1ad8337 to 9b8447a Compare August 2, 2024 16:20
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 2, 2024
…method docs to fix errors when generating HTML documentation
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 12, 2024
@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 41.12150% with 63 lines in your changes missing coverage. Please review.

Project coverage is 57.21%. Comparing base (8127837) to head (a73b72c).
Report is 1 commits behind head on main.

Files Patch % Lines
src/ansys/sherlock/core/layer.py 36.73% 62 Missing ⚠️
src/ansys/sherlock/core/errors.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   57.61%   57.21%   -0.40%     
==========================================
  Files          21       21              
  Lines        4327     4434     +107     
==========================================
+ Hits         2493     2537      +44     
- Misses       1834     1897      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand merged commit 6e41492 into main Aug 12, 2024
@ansnfernand ansnfernand deleted the addModelingRegion branch August 12, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pySherlock API for add, update, copy and delete modeling regions

3 participants