Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@github-actions github-actions bot added dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related labels Aug 2, 2024
@codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.61%. Comparing base (bf7492b) to head (86bafec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   57.61%   57.61%           
=======================================
  Files          21       21           
  Lines        4327     4327           
=======================================
  Hits         2493     2493           
  Misses       1834     1834           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand requested a review from ansjmoody August 2, 2024 09:09
@ansjmoody ansjmoody merged commit 5386bf2 into main Aug 2, 2024
@ansjmoody ansjmoody deleted the preCommitUpdate branch August 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants