Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Nov 21, 2025

Description

Fixed unit tests

Issue linked

#668

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Check vulnerabilities locally
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Nov 21, 2025
@ansnfernand ansnfernand self-assigned this Nov 21, 2025
@ansnfernand ansnfernand added the bug Something isn't working label Nov 21, 2025
@github-actions github-actions bot added the testing Anything related to tests label Nov 21, 2025
@ansnfernand ansnfernand linked an issue Nov 21, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 21, 2025
@ansnfernand ansnfernand enabled auto-merge (squash) November 21, 2025 14:43
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.00%. Comparing base (d34a9b2) to head (82fb7c6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/common.py 0.00% 3 Missing ⚠️
src/ansys/sherlock/core/errors.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   62.99%   63.00%           
=======================================
  Files          22       22           
  Lines        6197     6200    +3     
=======================================
+ Hits         3904     3906    +2     
- Misses       2293     2294    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand merged commit 9328091 into main Nov 21, 2025
27 of 28 checks passed
@ansnfernand ansnfernand deleted the fixUnitTestErrors branch November 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in helper_test_get_stackup_props

4 participants