Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/671.test.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: fixed unit tests
6 changes: 3 additions & 3 deletions src/ansys/sherlock/core/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@ def list_solder_materials(self) -> list[str]:
if not self._is_connection_up():
raise SherlockNoGrpcConnectionException()

request = SherlockCommonService_pb2.GetSoldersRequest()
response = self.stub.getSolders(request)
request = SherlockCommonService_pb2.SolderInfoRequest()
response = self.stub.getSolderInfo(request)

return response.solderName
return response.solders

@require_version(251)
def get_sherlock_info(self) -> str:
Expand Down
8 changes: 6 additions & 2 deletions src/ansys/sherlock/core/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,17 @@ def str_itr(self):
class SherlockAddRandomVibeEventError(Exception):
"""Contains the errors raised when a random vibe event cannot be added."""

def __init__(self, message: str):
def __init__(self, message: Optional[str] = None, error_array: Optional[list[str]] = None):
"""Initialize error message."""
self.message = message
self.error_array = error_array

def str_itr(self):
"""Create list of error messages."""
if self.message is not None:
if self.error_array is not None:
return [f"Add random vibe event error: {error}" for error in self.error_array]

elif self.message is not None:
return [f"Add random vibe event error: {self.message}"]


Expand Down
1 change: 1 addition & 0 deletions tests/test_lifecycle.py
Original file line number Diff line number Diff line change
Expand Up @@ -2257,6 +2257,7 @@ def helper_test_load_harmonic_profile(lifecycle: Lifecycle):
"Phase 1",
"Harmonic Event",
"Test_Profile.dat",
"x",
)
pytest.fail("No exception raised when using an invalid parameter")
except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_parts.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def helper_test_update_parts_from_AVL(parts: Parts):
avl_description=AVLDescription.ASSIGN_APPROVED_DESCRIPTION,
)

assert response.returnCode.value == 0
assert response == 0
except SherlockUpdatePartsFromAVLError as e:
pytest.fail(e.message)

Expand Down
Loading