Skip to content

Conversation

@ansys-pwalters
Copy link
Collaborator

Description

Added get_mount_point_props and update_mount_points methods.

Issue linked

Resolves #611

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Check vulnerabilities locally
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.07%. Comparing base (9328091) to head (128a334).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/layer_types.py 69.02% 35 Missing ⚠️
src/ansys/sherlock/core/layer.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   63.00%   63.07%   +0.07%     
==========================================
  Files          22       22              
  Lines        6200     6323     +123     
==========================================
+ Hits         3906     3988      +82     
- Misses       2294     2335      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand added this to the 2026 R1 milestone Nov 24, 2025
@ansnfernand ansnfernand merged commit c93d7d0 into main Nov 24, 2025
28 checks passed
@ansnfernand ansnfernand deleted the paul/mp1121 branch November 24, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API: update_mount_point_properties()

4 participants