Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 78.12% 78.84% +0.72%
==========================================
Files 14 14
Lines 1495 1513 +18
Branches 235 234 -1
==========================================
+ Hits 1168 1193 +25
+ Misses 267 262 -5
+ Partials 60 58 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ansfbessier
reviewed
Jul 15, 2025
|
[like] Frederic Bessiere reacted to your message:
________________________________
From: Jean Henry ***@***.***>
Sent: Tuesday, July 15, 2025 1:42:21 PM
To: ansys/scade-python-wrapper ***@***.***>
Cc: Frederic Bessiere ***@***.***>; Review requested ***@***.***>
Subject: Re: [ansys/scade-python-wrapper] fix: Enhance robustness (PR #37)
[External Sender]
@ansjhenry commented on this pull request.
________________________________
In src/ansys/scade/python_wrapper/swan_data_parser.py<#37 (comment)>:
@@ -62,7 +63,7 @@ class EK(Enum):
_c_id_j = {}
…-def _get_model(model: data.Model, c_id: int, role: str = None) -> data.Entity:
+def _get_model(model: data.Model, c_id: int, role: str) -> data.Entity:
Yes, if we maintain the default value. The change consists in making the parameter mandatory since it is always provided.
—
Reply to this email directly, view it on GitHub<#37 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFEE3PADNQ26TDZPPDIYG2L3IUAL3AVCNFSM6AAAAACBRN4OXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRQGM3TINBXHA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
ansfbessier
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the package's robustness with the following actions:
execcalls