Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master into feature #21818

Merged
merged 36 commits into from Mar 3, 2020
Merged

chore: merge master into feature #21818

merged 36 commits into from Mar 3, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered README-pt_BR.md
View rendered README-zh_CN.md
View rendered README.md
View rendered components/button/index.en-US.md
View rendered components/button/index.zh-CN.md
View rendered components/carousel/index.en-US.md
View rendered components/carousel/index.zh-CN.md
View rendered components/cascader/index.en-US.md
View rendered components/cascader/index.zh-CN.md
View rendered components/config-provider/demo/direction.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md
View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

zombieJ and others added 30 commits February 29, 2020 23:35
* fix: Table.Column sortOrder is not working in JSX mode

* clean up

* update snapshot
* 🎬 fix @ant-design/icons dep in Stackblitz

close #21718

* fix codepen cdn url
* alert

* more icons

* another grouping

* all done
* fix: Menu.item inline a tag display not correct

* add :only-child
* fix: Table locale not work

* add test case
Adjust space error in link and point to en-US version.
This comment was an accidental copy/pasta from https://reactjs.org/docs/error-boundaries.html.  Also, it is inaccurate since the user (i.e. AntD user) cannot actually render any fallback component.
Signed-off-by: TennyZhuang <zty0826@gmail.com>
* add support use dots to provide dotsClasse

* update docs
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@afc163
Copy link
Member Author

afc163 commented Mar 3, 2020

approve needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 3, 2020

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2020

This pull request fixes 2 alerts when merging 30a3c32 into 84173d9 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c928952:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #21818 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #21818      +/-   ##
===========================================
+ Coverage    97.88%   97.88%   +<.01%     
===========================================
  Files          305      305              
  Lines         7001     7003       +2     
  Branches      1889     1933      +44     
===========================================
+ Hits          6853     6855       +2     
  Misses         148      148
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️
components/tree/Tree.tsx 100% <ø> (ø) ⬆️
components/layout/Sider.tsx 97.61% <ø> (ø) ⬆️
components/input/Search.tsx 97.26% <ø> (ø) ⬆️
components/typography/Editable.tsx 100% <ø> (ø) ⬆️
components/steps/index.tsx 100% <ø> (ø) ⬆️
components/tabs/TabBar.tsx 100% <ø> (ø) ⬆️
components/modal/confirm.tsx 97.5% <ø> (ø) ⬆️
components/page-header/index.tsx 100% <ø> (ø) ⬆️
components/input-number/index.tsx 100% <ø> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105c393...c928952. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2020

This pull request fixes 2 alerts when merging c928952 into 84173d9 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet