🐛 fix: fix compatible with subscribe api#89
Merged
Conversation
|
🎊 PR Preview 349d283 has been successfully built and deployed to https://ant-design-pro-editor-preview-pr-89.surge.sh 🕐 Build time: 91.276s 🤖 By surge-preview |
4e3ebfb to
ebb1085
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## alpha #89 +/- ##
========================================
Coverage ? 87.57%
========================================
Files ? 350
Lines ? 22494
Branches ? 1034
========================================
Hits ? 19698
Misses ? 2796
Partials ? 0 ☔ View full report in Codecov by Sentry. |
rdmclin2
pushed a commit
that referenced
this pull request
Sep 14, 2023
## [Version 0.21.0-alpha.1](v0.20.2...v0.21.0-alpha.1) <sup>Released on **2023-09-14**</sup> #### ✨ 新特性 - Undo/redo Middleware. #### 🐛 修复 - Fix compatible with subscribeWithSelector middleware. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * Undo/redo Middleware, closes [#74](#74) ([7699738](7699738)) #### What's fixed * Fix compatible with subscribeWithSelector middleware, closes [#89](#89) ([24ffb15](24ffb15)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 0.21.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
arvinxx
added a commit
that referenced
this pull request
Nov 24, 2023
* 🐛 fix: fix compatible with subscribe api * ✅ test: upgrade @testing-library/jest-dom
rdmclin2
pushed a commit
that referenced
this pull request
Nov 24, 2023
## [Version 0.28.0-alpha.1](v0.27.0...v0.28.0-alpha.1) <sup>Released on **2023-11-24**</sup> #### ✨ 新特性 - Undo/redo Middleware. #### 🐛 修复 - Fix compatible with subscribeWithSelector middleware. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * Undo/redo Middleware, closes [#74](#74) ([44551aa](44551aa)) #### What's fixed * Fix compatible with subscribeWithSelector middleware, closes [#89](#89) ([b11cb36](b11cb36)) </details> <div align="right"> [](#readme-top) </div>
rdmclin2
pushed a commit
that referenced
this pull request
Nov 24, 2023
## [Version 0.28.0](v0.27.0...v0.28.0) <sup>Released on **2023-11-24**</sup> #### ✨ 新特性 - Undo/redo Middleware. #### 🐛 修复 - Fix compatible with subscribeWithSelector middleware. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * Undo/redo Middleware, closes [#74](#74) ([44551aa](44551aa)) #### What's fixed * Fix compatible with subscribeWithSelector middleware, closes [#89](#89) ([b11cb36](b11cb36)) </details> <div align="right"> [](#readme-top) </div>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

先前一版实现,在搭配
subscribeWithSelector时,监听能力会失效。经过排查发现之前的实现逻辑中初始化 state 的传入的方法(set,get,api),api 是解构引入的,这似乎使得
subscribeWithSelector中间件的修改逻辑失效了:通过不修改
api对象,换成setState方法的替换即可。