fix(attachments): add cardType for FileCard #1610
Conversation
…o fix-Attachments
…o fix-Attachments
…o fix-Attachments
|
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthrough本次变更为附件组件引入泛型（Attachment、AttachmentsProps）、将文件列表状态从 useMergedState 改为 useControlledState、FileCard 内部类型处理改为 CARD_TYPE 枚举，并调整 FileList 中构造 FileCardProps 的字段来源（使用 item.cardType 作为 type）。 Changes
Sequence Diagram(s)（本次改动未满足生成顺序图的条件：变更以类型、局部逻辑和内部常量为主，交互方不足以形成多组件顺序流程图。） Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 分钟 诗
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @kimteayon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on improving the type handling and flexibility of file attachments within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a property name collision for type on attachment items by introducing cardType. The refactoring to use a CARD_TYPE enum in FileCard.tsx is a great improvement for maintainability, replacing magic strings with a more robust and type-safe approach. The update from useMergedState to useControlledState is also a welcome modernization. My review includes one comment to remove a leftover debugging statement.
Deploying ant-design-x with
|
| Latest commit: |
6ca4410
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7bf67d78.ant-design-x.pages.dev |
| Branch Preview URL: | https://fix-attachments-cvk4.ant-design-x.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/x/components/file-card/FileCard.tsx (1)
28-33: 考虑导出 CARD_TYPE 枚举以提高类型安全性。当前
CARD_TYPE枚举仅在文件内部使用，但FileCardProps.type的类型定义为`${CARD_TYPE}`。考虑导出此枚举，以便外部调用方可以使用类型安全的常量而不是字符串字面量。🔎 建议的改进
-enum CARD_TYPE { +export enum CARD_TYPE { FILE = 'file', IMAGE = 'image', AUDIO = 'audio', VIDEO = 'video', }
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/x/components/attachments/FileList/index.tsxpackages/x/components/attachments/index.tsxpackages/x/components/attachments/index.zh-CN.mdpackages/x/components/file-card/FileCard.tsxpackages/x/package.json
🧰 Additional context used
🧬 Code graph analysis (1)
packages/x/components/file-card/FileCard.tsx (1)
packages/x/components/file-card/utils.ts (1)
matchExt(14-16)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build preview
- GitHub Check: size
- GitHub Check: test
- GitHub Check: test
🔇 Additional comments (6)
packages/x/components/attachments/index.zh-CN.md (1)
55-60: 文档更新准确。新增的
Attachment接口文档清晰地说明了cardType属性的用途，与代码实现保持一致。packages/x/components/file-card/FileCard.tsx (2)
248-257: 代码重构提升了一致性。使用
CARD_TYPE枚举值替代字符串字面量，增强了代码的可维护性和类型安全性。
70-70: 类型定义更改未发现破坏性变更。在整个代码库中，
FileCard的type属性的所有用法都仅使用标准枚举值（'file'、'image'、'audio'、'video'），没有发现任何自定义或非标准的类型值。所有现有代码与新的严格类型定义`${CARD_TYPE}`完全兼容。此改动实际上是一个改进，它在编译时强制执行类型检查，确保了更强的类型安全性。Likely an incorrect or invalid review comment.
packages/x/components/attachments/index.tsx (3)
1-3: 验证 useControlledState 替换 useMergedState 的行为一致性。代码从
useMergedState切换到useControlledState。请确认两者在受控/非受控模式下的行为一致，特别是初始值处理和更新逻辑。
21-26: 泛型接口设计合理。新增的
Attachment<T>接口扩展了UploadFile<T>并添加了cardType属性，提供了良好的类型安全性和灵活性。cardType作为可选属性，允许向后兼容。
28-54: 泛型 AttachmentsProps 提升了类型安全。将
AttachmentsProps改为泛型类型，配合Attachment<T>[]，使得类型系统更加健壮，能够在编译时捕获更多类型错误。
…o fix-Attachments
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 140 140
Lines 4263 4263
Branches 1200 1203 +3
=======================================
Hits 4048 4048
Misses 213 213
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 1.51MB (80.72%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antdx-array-pushAssets Changed:
view changes for bundle: x-markdown-array-pushAssets Changed:
|
* chore: changelog of 2.1.2 (#1603) * chore: changelog of 2.1.2 * chore: changelog of 2.1.2 * chore: actions docs (#1605) * feat: test * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * test: x-sdk * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * test: x-sdk * test: x-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * test: x-sdk * test: x-sdk * test: x-sdk * test: x-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat: push * fix: geshi * fix: geshi * fix: classnames => clsx and add noUndeclaredDependencies config (#1608) * chore: changelog of 2.1.3 (#1614) * chore: changelog of 2.1.3 * chore: changelog of 2.1.3 * chore: changelog of 2.1.3 * chore(deps-dev): bump inquirer from 12.11.1 to 13.1.0 (#1536) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump openai from 5.23.2 to 6.14.0 (#1538) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Modified the error in writing the extension budget symbol in markdown (#1615) * fix(attachments): add cardType for FileCard (#1610) * fix: attachments * fix: attachments * feat: browseeruse * test: snap * test: snap * test: file card * test: file card * test: file card * feat: test * feat: test * fix: attachments * fix: attachments * fix: attachments * fix(Sender): inster container & position & update slot test (#1612) * fix: inster container * feat: cursor * feat: cursor * feat: cursor * feat: slot test * test: custom slot * feat: test of sender * feat: test of sender * test: sender * test: sender * feat: hook cursor * feat: hook cursor * feat: hook cursor --------- Co-authored-by: Mickey <951203214@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bbimasheep <75004889+Yx0201@users.noreply.github.com>
* feat(XSdk): XRequest support retry * chore: changelog of 2.1.2 (#1603) * chore: changelog of 2.1.2 * chore: changelog of 2.1.2 * chore: actions docs (#1605) * feat: test * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * test: x-sdk * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * feat: x-sdk default messages * test: x-sdk * test: x-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * test: x-sdk * test: x-sdk * test: x-sdk * test: x-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat:s-sdk * feat: push * fix: geshi * fix: geshi * fix: classnames => clsx and add noUndeclaredDependencies config (#1608) * chore: changelog of 2.1.3 (#1614) * chore: changelog of 2.1.3 * chore: changelog of 2.1.3 * chore: changelog of 2.1.3 * chore(deps-dev): bump inquirer from 12.11.1 to 13.1.0 (#1536) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump openai from 5.23.2 to 6.14.0 (#1538) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Modified the error in writing the extension budget symbol in markdown (#1615) * fix(attachments): add cardType for FileCard (#1610) * fix: attachments * fix: attachments * feat: browseeruse * test: snap * test: snap * test: file card * test: file card * test: file card * feat: test * feat: test * fix: attachments * fix: attachments * fix: attachments * fix(Sender): inster container & position & update slot test (#1612) * fix: inster container * feat: cursor * feat: cursor * feat: cursor * feat: slot test * test: custom slot * feat: test of sender * feat: test of sender * test: sender * test: sender * feat: hook cursor * feat: hook cursor * feat: hook cursor * feat: optimize retry * refactor: optimize retry --------- Co-authored-by: Mickey <951203214@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bbimasheep <75004889+Yx0201@users.noreply.github.com>
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
Summary by CodeRabbit
发布说明
新功能
改进
文档
✏️ Tip: You can customize this high-level summary in your review settings.