Fix bugs and code quality issues from code review#3
Merged
Conversation
- Remove unused top-level mimetypes list - Fix timezone bug in episode_too_old: use utcfromtimestamp instead of fromtimestamp - Extract _make_feed_folder helper to deduplicate folder creation logic in import_feed - Replace O(n²) nested loop in update_feed with O(1) set-based deduplication - Remove redundant hasattr check in episodes_from_feed - Replace bare except with specific (KeyError, IndexError) in download_single - Fix Content-Length KeyError in download_single by using headers.get with fallback - Fix rename crash: call find_feed before os.rename so the feed file can still be found - Guard against empty episode list in pretty_print_feeds - Add missing exit(0) after rename command in main Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan