fix(statistics): add probability() function#115
Merged
antfullstack merged 1 commit intoantfullstack:mainfrom Apr 12, 2026
Merged
fix(statistics): add probability() function#115antfullstack merged 1 commit intoantfullstack:mainfrom
antfullstack merged 1 commit intoantfullstack:mainfrom
Conversation
Implement probability(favorable_outcomes, possible_outcomes) in statistics.py. Returns favorable_outcomes / possible_outcomes as a float — e.g. probability(1, 6) ≈ 0.1667 (rolling a specific value on a dice). Guards: - Raises ValueError when possible_outcomes == 0 - Raises ValueError when either argument is negative
Owner
|
Thank you very mush for your contribution! I really appreciate the error handling considerations and structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #105 requested a
probability()function instatistics.pythat computesfavorable_outcomes / possible_outcomesand returns a float approximation — e.g. the probability of rolling a 4 on a die isprobability(1, 6)→0.1666...Solution
Added
probability(favorable_outcomes, possible_outcomes)with:ValueErrorguard whenpossible_outcomes == 0ValueErrorguard when either argument is negativeFiles Changed
simple_equ/economics/statistics.py— addedprobability()functionVerification
Closes #105