Skip to content

use hgraph route for ivf#508

Merged
LHT129 merged 1 commit intoantgroup:mainfrom
LHT129:hgraph_ivf
Apr 22, 2025
Merged

use hgraph route for ivf#508
LHT129 merged 1 commit intoantgroup:mainfrom
LHT129:hgraph_ivf

Conversation

@LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Mar 18, 2025

No description provided.

@LHT129 LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.14 labels Mar 18, 2025
@LHT129 LHT129 self-assigned this Mar 18, 2025
@LHT129 LHT129 requested review from inabao and wxyucs as code owners March 18, 2025 09:45
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   90.61%   90.51%   -0.10%     
==========================================
  Files         194      194              
  Lines       11909    11907       -2     
==========================================
- Hits        10791    10778      -13     
- Misses       1118     1129      +11     
Flag Coverage Δ
cpp 90.51% <66.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.26% <ø> (+0.08%) ⬆️
datacell 91.60% <ø> (-0.13%) ⬇️
index 89.29% <66.66%> (-0.17%) ⬇️
simd 87.24% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac47559...ba40d2d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 21, 2025
@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 21, 2025
@LHT129 LHT129 force-pushed the hgraph_ivf branch 5 times, most recently from e339e24 to 1d585b5 Compare March 27, 2025 06:48
@LHT129 LHT129 marked this pull request as draft March 27, 2025 08:14
@LHT129 LHT129 changed the title use hgraph route for ivf [WIP] use hgraph route for ivf Mar 27, 2025
@LHT129 LHT129 force-pushed the hgraph_ivf branch 2 times, most recently from e03706c to f1355c2 Compare April 7, 2025 06:03
@LHT129 LHT129 force-pushed the hgraph_ivf branch 2 times, most recently from 913c32a to 8b30df8 Compare April 9, 2025 09:22
@LHT129 LHT129 force-pushed the hgraph_ivf branch 3 times, most recently from 888be63 to c7c6aec Compare April 21, 2025 07:21
@LHT129 LHT129 changed the title [WIP] use hgraph route for ivf use hgraph route for ivf Apr 21, 2025
@LHT129 LHT129 marked this pull request as ready for review April 21, 2025 07:21
QuantizerParameter::GetQuantizerParameterByJson(quantizer_json);
ParamPtr param_ptr;
// JsonType brute_force_json = {};
// param_ptr = BruteForce::CheckAndMappingExternalParam(brute_force_json, common_param);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 merged commit cbd2ea9 into antgroup:main Apr 22, 2025
22 of 24 checks passed
@LHT129 LHT129 deleted the hgraph_ivf branch May 21, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/testing size/M version/0.15

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants