disable simd instructions in diskann #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxyucs
added
kind/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 189 189
Lines 11437 11440 +3
=======================================
+ Hits 10442 10445 +3
Misses 995 995
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
wxyucs
force-pushed
the
remove-diskann-simd
branch
from
6579d6a to
d578ba2
Compare
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
wxyucs
force-pushed
the
remove-diskann-simd
branch
from
d578ba2 to
84b07b9
Compare
wxyucs
added a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #696
SIMD instructions (avx,sse, ..), in diskann, are not used by vsag now, so we can disable these codes to avoid
illegal instructionshappened on some old platforms.