Skip to content

support ivfpq fastscan #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LHT129 merged 1 commit into from
May 15, 2025
Merged

support ivfpq fastscan #702

LHT129 merged 1 commit into from
May 15, 2025

Conversation

@LHT129
Copy link
Collaborator

@LHT129 LHT129 commented May 13, 2025

closed: #701

@LHT129 LHT129 self-assigned this May 13, 2025
@LHT129 LHT129 requested a review from inabao as a code owner May 13, 2025 07:02
@LHT129 LHT129 added the kind/feature New feature or request label May 13, 2025
@LHT129 LHT129 requested a review from wxyucs as a code owner May 13, 2025 07:02
@LHT129 LHT129 force-pushed the ivfpqfs branch 6 times, most recently from 3161b37 to 10b9091 Compare May 14, 2025 06:04
@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   91.34%   90.99%   -0.36%     
==========================================
  Files         190      190              
  Lines       11664    11710      +46     
==========================================
+ Hits        10655    10656       +1     
- Misses       1009     1054      +45
Flag Coverage Δ
cpp 90.99% <93.18%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.07% <ø> (ø)
datacell 92.51% <90.32%> (+0.08%) ⬆️
index 88.57% <100.00%> (-0.75%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f19fda...0e5956c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129 LHT129 force-pushed the ivfpqfs branch 2 times, most recently from 1d283ad to a22f3ee Compare May 15, 2025 03:42
@LHT129
support ivfpq fastscan
0e5956c 
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
inabao approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 merged commit cce585e into antgroup:main May 15, 2025
28 of 30 checks passed
@LHT129 LHT129 deleted the ivfpqfs branch May 15, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxyucs wxyucs wxyucs approved these changes

@inabao inabao inabao approved these changes

@ShawnShawnYou ShawnShawnYou ShawnShawnYou approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@LHT129 LHT129

Labels

kind/feature New feature or request module/testing size/L version/0.15

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support IVFPQFS

4 participants

@LHT129 @wxyucs @inabao @ShawnShawnYou