Add arrow-key shortcuts for workspace/tab switching#1
Open
Conversation
Add Cmd+Shift+Right/Left as alternative shortcuts for next/previous surface switching (alongside existing Cmd+Shift+]/[), and Cmd+Ctrl+Right/Left for next/previous workspace switching (alongside existing Cmd+Ctrl+]/[). Arrow keys are more intuitive for directional navigation. The existing bracket shortcuts are preserved unchanged. When the browser address bar is focused, Cmd+Shift+Arrow is passed through to text editing (select-to-line-boundary) instead of being consumed by surface switching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nt and simplify flags intersection
…tchShortcut behavior Arrow-key workspace/surface shortcuts silently failed when CapsLock was on because matchArrowShortcut did not subtract .capsLock from modifier flags. Add .capsLock to the subtracting set to be consistent with matchShortcut. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The existing bypass only checked for address bar focus, so Cmd+Shift+Left/Right was still intercepted for surface switching when a page <input>, <textarea>, or contentEditable element had focus. Extend the check to also detect when a CmuxWebView (or its WebKit subview) is the first responder via a lightweight responder-chain walk, so standard text selection works in all browser text inputs. Addresses CodeRabbit review comment on PR manaflow-ai#2057. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+Shift+]/[Cmd+Ctrl+]/[Cmd+Shift+Arrowis passed through to text editing (select-to-line-boundary) so it does not interfere with text selectionArrow keys are more intuitive for directional navigation. All existing bracket-based shortcuts are preserved unchanged.
Test plan
🤖 Generated with Claude Code