[codex] avoid redundant uint64 varint casts#31
Merged
Conversation
Emit direct varint_size calls for generated uint64 encoded-size expressions while preserving explicit casts for other scalar conversions. Call write_varint directly from the uint64 runtime writer and regenerate smoke outputs. Add focused Python codegen coverage plus a C++ smoke test for canonical uint64 varint bytes.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varint_size(value)calls for generateduint64encoded-size expressions instead of redundantstatic_cast<::protocyte::u64>(...)wrappers.write_varint(writer, value)directly from the runtimewrite_uint64helper.Validation
clang-format --dry-run --Werroron touched C++ filesuv run pytest -q(99 passed)smoke\build\msvc\protocyte_host_smoke.exe "write_uint64 emits canonical varint bytes"git diff --checkVsDevCmd.bat:ninja: no work to do