[Async] Migrate Query<T> result from List<T> to IAsyncQueryable<T>#1
Merged
anthonyreilly merged 2 commits intoanthonyreilly:dev-asyncbatchfrom Mar 2, 2018
Merged
Conversation
Query<T> iterates asynchronously through Batches to avoid pre-loading all of them before returning the first item.
Owner
|
Thanks for this, I've been wanting to add async batching, and I'll be able to test it against some large batches. I'll probably need to modify it a bit though to preserve backwards compatibility. |
Author
|
I thought that as we go to version 2.0, we could break the compatibility. |
anthonyreilly
added a commit
that referenced
this pull request
Mar 2, 2018
…syncEnumerable/Ix.NET extensions. Modified from PR #1
Owner
|
For now I'm trying to minimize any breaking changes - the main reason I bumped to v2.0 was because I was dropping netstandard1.3 compatibility. I'm merging your changes in as a new function (calling it "QueryAsync") and leaving he existing interfaces for now. I've run some tests against large batches and everything looks good so far. |
anthonyreilly
pushed a commit
that referenced
this pull request
Oct 3, 2018
Use CreateResponse object for return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query iterates asynchronously through Batches to avoid pre-loading all of them before returning the first item.
All test succeeds, but I can't test on a real batched query (not enough data in my salesforce Sandbox)