fix(buffa-codegen): omit empty ancillary content files#107
Open
yordis wants to merge 2 commits intoanthropics:mainfrom
Open
fix(buffa-codegen): omit empty ancillary content files#107yordis wants to merge 2 commits intoanthropics:mainfrom
yordis wants to merge 2 commits intoanthropics:mainfrom
Conversation
The crate doc already promised that empty ancillary kinds are not emitted in default split mode, but the generator was writing header-only `.__oneof.rs`, `.__view_oneof.rs`, and `.__ext.rs` files for every input proto. In schemas with one message per file, the generated tree triples in size with placeholder files that surface in editors, search results, and review diffs while carrying no code. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Empty `pub mod view`/`oneof`/`ext` blocks (and the outer `__buffa` wrapper when none would have items) were still emitted, leaving dead namespace nodes in the generated tree. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Author
|
Technically, I "fixed" two issues since I also clean up the I can't find if such decision of leaving empty files around was intentional or not; so I decided to "fix" it. From the end-user perspective, I rather don't have such code around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedFile— empty ancillary kinds are no longer emitted, and the package stitcher onlyinclude!s files that exist.