ci: publish buffa-descriptor before buffa-types#160
Merged
Conversation
buffa-types gained an optional buffa-descriptor dependency (reflect feature), so cargo publish for buffa-types now requires buffa-descriptor to already be in the index. Swap the two steps to restore dependency order; no other edges changed.
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.7.0 publish run (26612133084) failed at the
Publish buffa-typesstep:The reflection work in 0.7.0 added an optional
buffa-descriptordependency tobuffa-types(behind thereflectfeature), but the workflow still publishesbuffa-typesbeforebuffa-descriptor. cargo publish requires optional dependencies to be resolvable from the index as well, so the step fails.Change
Swap the
buffa-descriptorandbuffa-typespublish steps and add a comment explaining the constraint. The rest of the order is already consistent with the workspace dependency graph (buffa → buffa-descriptor → buffa-types → buffa-codegen → buffa-build → protoc-gen-buffa → protoc-gen-buffa-packaging).Recovery for v0.7.0
buffa0.7.0 is already live on crates.io; the publish steps are idempotent. After this merges, re-dispatching the workflow (workflow_dispatchwithdry_run=false) will skipbuffaand publish the remaining six crates in the corrected order.