fix: update outdated MSRV comment in is_exact_integer#57
Merged
iainmcgin merged 2 commits intoanthropics:mainfrom Apr 23, 2026
Merged
fix: update outdated MSRV comment in is_exact_integer#57iainmcgin merged 2 commits intoanthropics:mainfrom
iainmcgin merged 2 commits intoanthropics:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
recheck |
The comment stated MSRV 1.81 but the workspace Cargo.toml specifies rust-version = "1.85". Update the comment to match the actual MSRV. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
8710d7a to
e5d527e
Compare
Collaborator
|
[claude code] Amended the commit on your behalf with recheck |
iainmcgin
approved these changes
Apr 23, 2026
Collaborator
iainmcgin
left a comment
There was a problem hiding this comment.
[claude code] One-line doc fix — updates stale MSRV reference from 1.81 to the actual workspace MSRV 1.85. The f64::trunc() / Rust 1.86 justification remains correct (MSRV 1.85 still can't use core's trunc). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buffa/src/json_helpers.rsfrom "1.81" to "1.85" to match the actualrust-versionspecified inCargo.toml.The comment in
is_exact_integer()stated the MSRV was 1.81, but the workspaceCargo.tomlhas specifiedrust-version = "1.85"since the beginning of the 0.3.x series.Test plan
Cargo.tomlrust-version is "1.85"🤖 Generated with Claude Code