Skip to content

fix: update outdated MSRV comment in is_exact_integer#57

Merged
iainmcgin merged 2 commits intoanthropics:mainfrom
hobostay:fix/outdated-msrv-comment
Apr 23, 2026
Merged

fix: update outdated MSRV comment in is_exact_integer#57
iainmcgin merged 2 commits intoanthropics:mainfrom
hobostay:fix/outdated-msrv-comment

Conversation

@hobostay
Copy link
Copy Markdown
Contributor

Summary

  • Updates the outdated MSRV comment in buffa/src/json_helpers.rs from "1.81" to "1.85" to match the actual rust-version specified in Cargo.toml.

The comment in is_exact_integer() stated the MSRV was 1.81, but the workspace Cargo.toml has specified rust-version = "1.85" since the beginning of the 0.3.x series.

Test plan

  • Verified Cargo.toml rust-version is "1.85"
  • Grep confirms this was the only reference to "MSRV 1.81" in the codebase

🤖 Generated with Claude Code

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hobostay
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@iainmcgin
Copy link
Copy Markdown
Collaborator

recheck

The comment stated MSRV 1.81 but the workspace Cargo.toml specifies
rust-version = "1.85". Update the comment to match the actual MSRV.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
@iainmcgin iainmcgin force-pushed the fix/outdated-msrv-comment branch from 8710d7a to e5d527e Compare April 23, 2026 03:46
github-actions Bot added a commit that referenced this pull request Apr 23, 2026
@iainmcgin
Copy link
Copy Markdown
Collaborator

[claude code] Amended the commit on your behalf with maintainer-can-modify push access — the original was authored as Test User <test@example.com>, which the CLA bot can't match to a GitHub account. The new commit is authored with your users.noreply.github.com email (GitHub's canonical privacy form), which resolves to your account.

recheck

Copy link
Copy Markdown
Collaborator

@iainmcgin iainmcgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude code] One-line doc fix — updates stale MSRV reference from 1.81 to the actual workspace MSRV 1.85. The f64::trunc() / Rust 1.86 justification remains correct (MSRV 1.85 still can't use core's trunc). Thanks!

@iainmcgin iainmcgin enabled auto-merge (squash) April 23, 2026 04:16
@iainmcgin iainmcgin merged commit 051a3ab into anthropics:main Apr 23, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants