feat: add read_only mode for tag workflows#1433
Draft
tarunag10 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
read_onlyinput for tag mode so review-only workflows can prevent Claude from receiving commit, push, or file-deletion tools.Fixes #1415.
Root cause
Tag mode always added write-capable tools after parsing user
claude_args:use_commit_signingis falseuse_commit_signingis trueThat meant workflows could narrow their own
--allowedTools, but the action still reintroduced write tools required for autofix workflows. This is surprising and unsafe for security review or comment-only automations.Changes
read_onlytoaction.ymland exports it asREAD_ONLY.context.inputs.readOnly.buildTagModeTools.read_only: true, keeps read/comment/CI tools and user-specified GitHub MCP tools, but skips:Bash(git add:*)Bash(git commit:*)Bash(git rm:*)mcp__github_file_ops__commit_filesmcp__github_file_ops__delete_filesread_onlyis unset or false.Validation
./node_modules/.bin/prettier --check .bun test test/modes/tag.test.ts test/github-context.test.tsbun run typecheck