client: tighten gRPC and gRPC-Web unary response parsing#147
Open
jeet-dekivadia wants to merge 1 commit into
Open
client: tighten gRPC and gRPC-Web unary response parsing#147jeet-dekivadia wants to merge 1 commit into
jeet-dekivadia wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Unary and client-streaming responses have a single-message shape. Failing fast avoids unnecessary decompression work and lets well-formed gRPC-Web responses finish without waiting for body EOF after trailers arrive.
Validation
git diff --checkcargo +nightly fmt --all -- --checkcargo check --workspace --all-features --all-targetscargo test --workspace --all-featurescargo clippy --workspace --all-features --all-targets -- -D warningsFixes #138