[benches] Update RPC benches for current client API#17
Merged
iainmcgin merged 2 commits intoanthropics:mainfrom Apr 1, 2026
Merged
[benches] Update RPC benches for current client API#17iainmcgin merged 2 commits intoanthropics:mainfrom
iainmcgin merged 2 commits intoanthropics:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the RPC benchmark code to match the current connectrpc client API. The client-stream benchmarks now call
client_stream(messages)without redundant default call options, the manual bidi benchmark request usesconnectrpc::client::full_body(...), and the staleCallOptionsimport was removed.Why
The benchmark code had drifted behind the current client API and helper usage.
Impact
The RPC benchmark crate builds cleanly against the current API, keeping the benchmark suite aligned with the library surface.
Root cause
The benchmark code still referenced an older client-stream call shape and body-construction path after the client helpers changed.
Validation
cargo check --manifest-path benches/rpc/Cargo.toml --benches