Skip to content

[benches] Update RPC benches for current client API#17

Merged
iainmcgin merged 2 commits intoanthropics:mainfrom
washanhanzi:main
Apr 1, 2026
Merged

[benches] Update RPC benches for current client API#17
iainmcgin merged 2 commits intoanthropics:mainfrom
washanhanzi:main

Conversation

@washanhanzi
Copy link
Copy Markdown
Contributor

Summary

This updates the RPC benchmark code to match the current connectrpc client API. The client-stream benchmarks now call client_stream(messages) without redundant default call options, the manual bidi benchmark request uses connectrpc::client::full_body(...), and the stale CallOptions import was removed.

Why

The benchmark code had drifted behind the current client API and helper usage.

Impact

The RPC benchmark crate builds cleanly against the current API, keeping the benchmark suite aligned with the library surface.

Root cause

The benchmark code still referenced an older client-stream call shape and body-construction path after the client helpers changed.

Validation

  • cargo check --manifest-path benches/rpc/Cargo.toml --benches

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@washanhanzi washanhanzi changed the title [codex] Update RPC benches for current client API [benches] Update RPC benches for current client API Mar 27, 2026
@washanhanzi
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@washanhanzi washanhanzi marked this pull request as ready for review March 27, 2026 05:14
@washanhanzi
Copy link
Copy Markdown
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Mar 27, 2026
Copy link
Copy Markdown
Collaborator

@iainmcgin iainmcgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! In #25 I'll enable --all-targets to avoid this regressing again in future.

@iainmcgin iainmcgin enabled auto-merge (squash) April 1, 2026 22:58
@iainmcgin iainmcgin merged commit a363272 into anthropics:main Apr 1, 2026
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants